Skip to content

Make MarginContainer available with disable_advanced_gui=yes#75367

Merged
YuriSizov merged 1 commit intogodotengine:masterfrom
Calinou:disable-advanced-gui-keep-margincontainer
Mar 27, 2023
Merged

Make MarginContainer available with disable_advanced_gui=yes#75367
YuriSizov merged 1 commit intogodotengine:masterfrom
Calinou:disable-advanced-gui-keep-margincontainer

Conversation

@Calinou
Copy link
Member

@Calinou Calinou commented Mar 26, 2023

Comparatively more advanced GUI nodes such as FlowContainer and AspectRatioContainer are already available when building with disable_advanced_gui=yes.

This increases binary size by about 8 KB for binaries compiled with disable_advanced_gui=yes (Linux release export template with LTO enabled).

For context, I'm working on a PR to display license notices in a GUI (similar to #51028). Having MarginContainer available in all situations would help a lot, so that the GUI can keep working in binaries compiled with disable_advanced_gui=yes.

# Current `master` branch when building with `disable_advanced_gui=yes`
60,355,504 godot.linuxbsd.template_release.x86_64.disable_advanced_gui_master

# MarginContainer enabled (what this PR does)
60,363,728 godot.linuxbsd.template_release.x86_64.disable_advanced_gui_pr_margincontainer_only

# MarginContainer, SplitContainer and SubViewportContainer enabled
# (not done in this PR, only included for reference)
60,421,040 godot.linuxbsd.template_release.x86_64.disable_advanced_gui_pr

# `disable_advanced_gui=no` (default)
62,809,040 godot.linuxbsd.template_release.x86_64.enable_advanced_gui

Comparatively more advanced GUI nodes such as FlowContainer and
AspectRatioContainer are already available when building with
`disable_advanced_gui=yes`.

This increases binary size by about 8 KB for binaries compiled with
`disable_advanced_gui=yes` (Linux release export template with LTO enabled).
@Calinou Calinou added this to the 4.x milestone Mar 26, 2023
@YuriSizov YuriSizov modified the milestones: 4.x, 4.1 Mar 27, 2023
Copy link
Contributor

@YuriSizov YuriSizov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, this is a weird exclusion, given what is still included.

@YuriSizov YuriSizov merged commit b136677 into godotengine:master Mar 27, 2023
@YuriSizov
Copy link
Contributor

Thanks!

@Calinou Calinou deleted the disable-advanced-gui-keep-margincontainer branch March 27, 2023 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants