Make MarginContainer available with disable_advanced_gui=yes#75367
Merged
YuriSizov merged 1 commit intogodotengine:masterfrom Mar 27, 2023
Merged
Conversation
Comparatively more advanced GUI nodes such as FlowContainer and AspectRatioContainer are already available when building with `disable_advanced_gui=yes`. This increases binary size by about 8 KB for binaries compiled with `disable_advanced_gui=yes` (Linux release export template with LTO enabled).
YuriSizov
approved these changes
Mar 27, 2023
Contributor
YuriSizov
left a comment
There was a problem hiding this comment.
Yeah, this is a weird exclusion, given what is still included.
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Comparatively more advanced GUI nodes such as FlowContainer and AspectRatioContainer are already available when building with
disable_advanced_gui=yes.This increases binary size by about 8 KB for binaries compiled with
disable_advanced_gui=yes(Linux release export template with LTO enabled).For context, I'm working on a PR to display license notices in a GUI (similar to #51028). Having MarginContainer available in all situations would help a lot, so that the GUI can keep working in binaries compiled with
disable_advanced_gui=yes.