Fix the Python type error when creating the .sln file

[HK-SHAO]

Fix: #74725

The error occurs at the statement env["CPPDEFINES"] + defines , where env["CPPDEFINES"] is of type <class 'collections.deque'> and defines is of type <class 'list'> .

Since the two types cannot be added together, list() function is used to convert deque to list.

After the modification, it can be compiled and generate the .sln file normally.

[RedworkDE]

Does this fix also work with scons 4.4.0? (downgrading to that is the current workaround in #74725) It probably should, just checking to ensure this fix doesn't break currently working setups / when or if scons fixes this on their end.

[HK-SHAO]

Does this fix also work with scons 4.4.0? (downgrading to that is the current workaround in #74725) It probably should, just checking to ensure this fix doesn't break currently working setups / when or if scons fixes this on their end.

This can solve the problem.

I compiled and generated .sln successfully in both v4.4.0.fc8d0ec215ee6cba8bc158ad40c099be0b598297 and v4.5.2.120fd4f633e9ef3cafbc0fec35306d7555ffd1db .

[akien-mga]

Should be fine for now as a workaround.

I see the SCons devs are discussing further changing CPPDEFINES to make sure it's properly coerced into list whenever it's being accessed, regardless of whether it's a list or deque internally.

So hopefully in a future 4.5.x or 4.6 release this workaround shouldn't be needed anymore. But it doesn't hurt to have it until then, and for some time to keep 4.5.0-4.5.2 working.

[akien-mga]

Thanks! And congrats for your first merged Godot contribution 🎉

[YuriSizov]

Cherry-picked for 4.0.3.

[ggsjyoon]

The fix worked with SCons v4.5.2. Thanks!

[akien-mga]

Cherry-picked for 3.6.

[akien-mga]

Cherry-picked for 3.5.3.