Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix collide_shape return type #75260

Merged
merged 1 commit into from
Mar 25, 2023
Merged

Fix collide_shape return type #75260

merged 1 commit into from
Mar 25, 2023
+12 −12

Conversation

rburing
Copy link
Member

@rburing rburing commented Mar 23, 2023

The type used to be a plain Array of vectors, so now it is a TypedArray of vectors.

For both 2D and 3D.

@rburing rburing requested a review from a team as a code owner March 23, 2023 15:08
@rburing
Fix collide_shape return type
61429a5 
Fix PhysicsDirectSpaceState3D::_collide_shape return type.
Also PhysicsDirectSpaceState2D::_collide_shape.
@rburing rburing requested a review from a team as a code owner March 23, 2023 15:16
@YuriSizov YuriSizov added this to the 4.1 milestone Mar 25, 2023
@YuriSizov YuriSizov merged commit 4640b55 into godotengine:master Mar 25, 2023
@YuriSizov
Copy link
Contributor

Thanks!

@YuriSizov
Copy link
Contributor

Cherry-picked for 4.0.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YuriSizov YuriSizov YuriSizov approved these changes

Assignees
No one assigned
Labels
bug topic:physics topic:2d topic:3d
Projects
None yet
Milestone
4.1
Development

Successfully merging this pull request may close these issues.

PhysicsDirectSpaceState collide_shape returns the wrong type
2 participants
@rburing @YuriSizov