Fix "Download Project Source" for Web Editor #75194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Correctly pass safe project name and safe datetime to `vformat`
|
Don't mind the milestone. It was assigned to the next available milestone, but it can still be cherry-picked for a 4.0.x release. |
YuriSizov
reviewed
Mar 21, 2023
YuriSizov
approved these changes
Mar 22, 2023
|
Thanks, good catch! |
|
Cherry-picked for 4.0.2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #74818
vformat()Important: @akien-mga added the issue to the 4.1 milestone, but this is entirely a regression fix. If it is delayed until 4.1, my Godot club will not be able to operate (I know we could downgrade to 3, but it made coding concepts a lot harder to teach). I was hoping this could be added to 4.0.2 instead?