Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added drag and drop support for shader include files in shader editor #74869

Merged
merged 1 commit into from
Mar 15, 2023
Merged

Added drag and drop support for shader include files in shader editor #74869

merged 1 commit into from
Mar 15, 2023
+9 −4

Conversation

fahadshihab
Copy link
Contributor

@fahadshihab fahadshihab commented Mar 13, 2023 •
edited by YuriSizov
Loading

This is in reference to issue #74392.

Production edit: Fixes #74392

@fahadshihab fahadshihab requested a review from a team as a code owner March 13, 2023 16:29
@clayjohn clayjohn added this to the 4.1 milestone Mar 13, 2023
clayjohn
clayjohn approved these changes Mar 14, 2023
View reviewed changes
Copy link
Member

@clayjohn clayjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Tested locally and it works

@fahadshihab fahadshihab force-pushed the master branch 2 times, most recently from 167310a to 49534d8 Compare March 15, 2023 13:48
@fahadshihab
Added drag and drop support for shaderinclude
e5601b5 
Dragging and dropping now works for shader include file.
@YuriSizov YuriSizov merged commit f08ffdc into godotengine:master Mar 15, 2023
@YuriSizov
Copy link
Contributor

Thanks, and congrats on your first merged pull request!

@fahadshihab
Copy link
Contributor Author

Thanks! @YuriSizov and @clayjohn

@YuriSizov
Copy link
Contributor

Cherry-picked for 4.0.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YuriSizov YuriSizov YuriSizov left review comments

@clayjohn clayjohn clayjohn approved these changes

Assignees
No one assigned
Labels
enhancement topic:editor topic:shaders
Projects
None yet
Milestone
4.1
Development

Successfully merging this pull request may close these issues.

Drag-dropping an .gdshaderinc into the shader editor does not open the shader
3 participants
@fahadshihab @YuriSizov @clayjohn