Fix null-pointer dereference on Android systems when using gl_compatibility renderer #74781
+7
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BastiaanOlij
approved these changes
Mar 11, 2023
clayjohn
approved these changes
Mar 12, 2023
|
Looks great, thanks! |
|
Cherry-picked for 4.0.1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes a null-pointer dereference crash on Android systems when using the gl_compatibility renderer. The vsync-mode functions assumed that VULKAN_ENABLED compiler define also implied that Vulkan was active at runtime. The result was that when the gl_compatibility renderer was used, the code would call member functions on the null vulkan context.