Use linear filtering without mipmaps for ProceduralSkyMaterial and PhysicalSkyMaterial #74740
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #74709
The blurriness at the pole and seam comes from the shader reading from a higher mipmap automatically. Mipmap detection works by measuring the size of the derivative of the UV. I.e. the further away the UV coordinate is from its neighbour, the higher level we can read from. This assumption breaks with panorama coordinates as there is a huge jump on the seam (from 1 to 0) leading to a very high mipmap being used for the pixels on the seam.
PanoramaSkyMaterial never uses mipmaps, but it has the option to enable/disable filtering. We could add the option in the future, but no one has asked for it, so its best to just keep things simple and continue to always use linear