-
-
Notifications
You must be signed in to change notification settings - Fork 21.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exposing more project settings for documentation #74727
Conversation
41dd64b
to
db9ca7e
Compare
I think the settings should be in a proper order now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of suggestions for the descriptions themselves, but LGTM otherwise.
db9ca7e
to
a0d02c3
Compare
Went ahead and updated the documentation in |
Identified a few more settings, editor related all of them, that still are inaccessible to documentation, will investigate if I can expose them. |
a0d02c3
to
bd30847
Compare
Went through and it looks like all settings in the If someone else wants to entertain themselves by looking if settings are exposed you can simply add something like "EMPTY" to the descriptions of all properties in |
Thanks! |
Thank you! |
Cherry-picked for 4.0.2. |
For project settings to be available for documentation, more importantly for doctool and ci to work, they have to be defined before this line:
godot/main/main.cpp
Line 2525 in d8e242c
Moved a number of settings from below this to
project_settings.cpp
, could also move them insidemain.cpp
but felt this was a better place to put them, can also move other settings out of main but left ones not causing this problem to keep the changes minimalDocumented a few of the settings that I had a clear idea of what they did and how to explain.