[3.x] Update the gradle build tasks to generate play store builds. #74583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m4gr3d
added
enhancement
platform:android
topic:buildsystem
topic:editor
topic:porting
cherrypick:3.5
m4gr3d
force-pushed
the
setup_play_store_builds_3x
branch
from
480de66
to
1cf6bd5
Compare
This was referenced Mar 8, 2023
m4gr3d
force-pushed
the
setup_play_store_builds_3x
branch
5 times, most recently
from
8babfab
to
a45b2e0
Compare
m4gr3d
commented
Apr 26, 2023
| supportedFlavors = ["editor", "template"] | ||
| supportedTargetsMapByFlavors = [ | ||
| "editor": [release: "release_debug", dev: "debug", debug: "release_debug"], |
There was a problem hiding this comment.
Change release builtype for the editor to storeRelease
There was a problem hiding this comment.
On further investigations, I'm sticking with release because every Android project has an automatic release build type. Changing it to storeRelease will require additional logic to disable the default release build type so we may as well leverage what already exists.
|
@akien-mga Updated this PR following our conversation. |
Configure the gradle builds to sign and build the release version of the Godot Android Editor
m4gr3d
force-pushed
the
setup_play_store_builds_3x
branch
from
a45b2e0
to
30e3e30
Compare
akien-mga
approved these changes
May 17, 2023
There was a problem hiding this comment.
Tested successfully on the official build server, with my edits to godotengine/godot-build-scripts#79.
|
Thanks! |
akien-mga
removed
the
cherrypick:3.5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Configure the gradle builds to sign and build the release version of the Godot Android Editor
Note: Should be merged alongside godotengine/godot-build-scripts#79
main version