Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes gutter set width results in receiving only half of the desired size #74537

Merged
merged 1 commit into from
Mar 20, 2023
Merged

Fixes gutter set width results in receiving only half of the desired size #74537

merged 1 commit into from
Mar 20, 2023

Conversation

nongvantinh
Copy link
Contributor

Fixes: #74458

At the beginning, CodeEdit::line_number_digits holds the value 0. But in CodeEdit::_text_changed() the value start from 1:

godot/scene/gui/code_edit.cpp

Line 3147 in c82948a

line_number_digits = 1;

@nongvantinh nongvantinh requested a review from a team as a code owner March 7, 2023 10:01
@akien-mga akien-mga changed the title Fixes gutter set width results in receiving only half of the desired… Fixes gutter set width results in receiving only half of the desired size Mar 7, 2023
@akien-mga akien-mga added this to the 4.1 milestone Mar 7, 2023
Paulb23
Paulb23 requested changes Mar 19, 2023
View reviewed changes
Copy link
Member

@Paulb23 Paulb23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we change the initial value to 1 instead, so it's consistent?

@YuriSizov YuriSizov merged commit cfe2a14 into godotengine:master Mar 20, 2023
@YuriSizov
Copy link
Contributor

Thanks!

@nongvantinh nongvantinh deleted the fix-74458 branch March 20, 2023 14:35
@YuriSizov
Copy link
Contributor

Cherry-picked for 4.0.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Paulb23 Paulb23 Paulb23 approved these changes

Assignees
No one assigned
Labels
bug topic:gui
Projects
None yet
Milestone
4.1
Development

Successfully merging this pull request may close these issues.

First CodeEdit typed line gets slightly offset to the left
4 participants
@nongvantinh @YuriSizov @Paulb23 @akien-mga