[3.x] Use the new API for virtual keyboard height detection on Android, bugfix for old API #74399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m4gr3d
reviewed
Mar 5, 2023
m4gr3d
approved these changes
Mar 5, 2023
|
Thanks for the review! I've made the requested change. Edit: The fixup commit is now squashed into the first one in accordance with PR Workflow. |
necrashter
force-pushed
the
3.x-android-vk-height
branch
from
79f7538
to
9bdb585
Compare
|
Thanks! |
m4gr3d
added
the
cherrypick:3.5
m4gr3d
removed
the
cherrypick:3.5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
3.x version of #74398.
I tested both APIs on Galaxy Note 10 Lite running Android 13 (features a navbar), and the old API on an Android 6 tablet (does not feature a navbar). Note that I couldn't test 4.x version on Android 6 tablet because it only supports OpenGL 2. Both portrait and landscape orientations were tested.