macOS export: Fix validation of codesigning certificate password #74326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you elaborate? What does this do? What issue does this fix? |
|
The fix seems correct, but indeed the commit message and PR title should be made more explicit about what this does. You can modify the commit message by amending the commit, and force pushing the changes, so that it stays as a single commit (see PR workflow). |
|
Also agree with @akien-mga this looks fine barring the commit message. If you no longer want to update this PR do let us know and we can sort out the fix. 👍 |
akien-mga
changed the title
akien-mga
approved these changes
Apr 11, 2023
|
Thanks! |
|
Cherry-picked for 4.0.3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.