Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix crash in resource load #74166

Merged
merged 1 commit into from
Mar 3, 2023
Merged

Fix crash in resource load #74166

merged 1 commit into from
Mar 3, 2023
+10 −2

Conversation

RandomShaper
Copy link
Member

The former code checked if the task still exists at a point by which it had already tried to read from it after its potential deletion.

@RandomShaper RandomShaper added this to the 4.1 milestone Mar 1, 2023
@RandomShaper RandomShaper requested a review from a team as a code owner March 1, 2023 17:32
@akien-mga akien-mga merged commit bdb3738 into godotengine:master Mar 3, 2023
@akien-mga
Copy link
Member

Thanks!

@RandomShaper RandomShaper deleted the fix_res_loader_read_freed branch March 3, 2023 10:56
@YuriSizov
Copy link
Contributor

Cherry-picked for 4.0.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
bug crash topic:core
Projects
None yet
Milestone
4.1
Development

Successfully merging this pull request may close these issues.
3 participants
@RandomShaper @akien-mga @YuriSizov