Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Windows to Windows SSH remote deploy. Fix Windows execute exit code. #74030

Merged
merged 1 commit into from
Mar 2, 2023
Merged

Fix Windows to Windows SSH remote deploy. Fix Windows execute exit code. #74030

merged 1 commit into from
Mar 2, 2023
+9 −2

Conversation

bruvzg
Copy link
Member

@bruvzg bruvzg commented Feb 27, 2023

  • Fixes remote deploy from Windows to Windows, when running on Windows, SSH command require different escaping.
  • Fixes Windows remote execute failing with empty arguments.
  • Fixes Windows execute exit code sometime set to STILL_ACTIVE (259) when using stdout pipe.

@bruvzg bruvzg added this to the 4.x milestone Feb 27, 2023
@bruvzg bruvzg requested a review from a team as a code owner February 27, 2023 08:03
@akien-mga akien-mga modified the milestones: 4.x, 4.0, 4.1 Feb 27, 2023
@akien-mga akien-mga merged commit aa9de8a into godotengine:master Mar 2, 2023
@akien-mga
Copy link
Member

Thanks!

@YuriSizov
Copy link
Contributor

Cherry-picked for 4.0.1.

@eh-jogos eh-jogos mentioned this pull request Mar 15, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
bug platform:windows topic:export topic:porting
Projects
None yet
Milestone
4.1
Development

Successfully merging this pull request may close these issues.
3 participants
@bruvzg @akien-mga @YuriSizov