Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

C#: Check if a class is a singleton using the Core name #73882

Merged
merged 1 commit into from
Feb 25, 2023
Merged

C#: Check if a class is a singleton using the Core name #73882

merged 1 commit into from
Feb 25, 2023

Conversation

raulsntos
Copy link
Member

Use the name of the class in Core, rather than the C# rename, when checking if a class is registered as a singleton.

@raulsntos
C#: Check if a class is a singleton using the Core name
3730d8e 
Use the name of the class in Core, rather than the C# rename, when checking if a class is registered as a singleton.
@raulsntos raulsntos requested a review from a team as a code owner February 24, 2023 17:03
@akien-mga akien-mga added this to the 4.0 milestone Feb 24, 2023
@akien-mga akien-mga merged commit 52033c6 into godotengine:master Feb 25, 2023
@akien-mga
Copy link
Member

Thanks!

@raulsntos raulsntos deleted the dotnet/check-singletons-properly branch February 25, 2023 01:11
@RedworkDE RedworkDE mentioned this pull request Mar 3, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
bug regression topic:dotnet
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.

No way to access ResourceUid class in C#
2 participants
@raulsntos @akien-mga