Correctly apply world_scale in WebXR (Godot 3.x) #71880
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsnopek
force-pushed
the
webxr-godot3-world-scale
branch
3 times, most recently
from
cb61327
to
736a625
Compare
|
Verified using the https://github.com/Malcolmnixon/AliceMaze demo project that world-scaling now works as expected. |
dsnopek
changed the title
|
@Malcolmnixon Thanks so much for finding this issue and testing the fix! |
dsnopek
changed the title
BastiaanOlij
approved these changes
Jan 23, 2023
dsnopek
force-pushed
the
webxr-godot3-world-scale
branch
from
736a625
to
82be475
Compare
|
Thanks @BastiaanOlij! The PR has been updated to address your feedback. It also turns out that the code in Godot 4 also wasn't correctly handling |
BastiaanOlij
approved these changes
Jan 24, 2023
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Malcolmnixon pointed out to me that, currently, WebXR (in Godot 3.x) doesn't take the
world_scalefromARVRServerinto account. (In Godot 4.x, it does attempt to do so!)But, unfortunately, it isn't fully working with Malcolm's AliceMaze example which is why it's still a draft.UPDATE: It is now working with Malcolm's example! This is ready :-)