Fixed RichTextLabel wrong selection offset after drop cap

[Koyper]

Fixes an issue in RichTextLabel where starting a selection, or selecting across a drop cap, would incorrectly start the selection offset by the width of the drop cap.

I would recommend leaving in the comments, because this is where a future improvement would fix the issue of the drop cap text not currently being selectable, and figuring out how to obtain the drop cap text is not obvious.

[Koyper]

Here are two comparison screen videos showing before/after PR fix.

Without the fix, the selection start is offset from the mouse location by the width of the dropcap:

Screen.Recording.2023-02-13.at.8.59.56.AM.mov

With the fix, the selection is correctly linked to the mouse location:

Screen.Recording.2023-02-13.at.9.02.44.AM.mov

[YuriSizov]

I would recommend leaving in the comments, because this is where a future improvement would fix the issue of the drop cap text not currently being selectable, and figuring out how to obtain the drop cap text is not obvious.

If this code is not valid yet, then there is no point leaving it there. You can stash the changes and work on it after we merge this. So please strip these lines from the PR.

[YuriSizov]

You need to squash your commits.

[Koyper]

If this code is not valid yet, then there is no point leaving it there. You can stash the changes and work on it after we merge this. So please strip these lines from the PR.

Is there a mechanism somewhere for adding code comments like this one for the benefit of a different, future contributor? I'll have my own comments, but it could save someone else some effort?

[YuriSizov]

Is there a mechanism somewhere for adding code comments like this one for the benefit of a different, future contributor? I'll have my own comments, but it could save someone else some effort?

You can comment your suggestion on an issue which you are trying to solve. If there is no issue, you can open one and leave a comment there.

Code comments aren't discoverable and having dead code in the codebase is mostly just contributes to the noise. And you also cannot guarantee that your solution is the correct one, so leaving it in the code would be misleading.

[YuriSizov]

LGTM. bruvzg approved, commented out lines were removed.

[YuriSizov]

Thanks!

[Koyper]

Code comments aren't discoverable and having dead code in the codebase is mostly just contributes to the noise. And you also cannot guarantee that your solution is the correct one, so leaving it in the code would be misleading.

I agree with these good observations - thanks!