-
-
Notifications
You must be signed in to change notification settings - Fork 21.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add next/reset function to AnimationStateMachine
#71264
Add next/reset function to AnimationStateMachine
#71264
Conversation
c387b77
to
95a0372
Compare
This looks good, though as we discussed in messages, I'm considering feeling that the name should probably be chosen as opposed to the broad 'interrupt' function since it could have a variety of different meanings. I also still need to properly evaluate requirements for the 'reset' flag, but I'll do a full review soon! |
b8c0793
to
4af0d91
Compare
If reset is false, it would be correct to move to the further next state with processing no frame if the next state has already ended, but the current end process is a bit odd to begin with (I guess that it is probably related to #68986), so I will look at this in the next PR. |
4af0d91
to
0ce6951
Compare
0ce6951
to
8bfaf09
Compare
Looks good to me, but make sure to agree on the naming |
AnimationStateMachine
AnimationStateMachine
Thanks! |
Closes godotengine/godot-proposals#2200
Closes godotengine/godot-proposals#5964
sti1.mp4
reset
option, which was added to NodeTransition under the namefrom_start
(see also Addsync
toNodeTransition
andBlendSpace1D/2D
and refactorsync
inAnimationTree
#62623), but since it is confusing with the StateMachine Start node, it is unifiedreset
. I don't have any idea how this would be useful for non-looping animations, but for looping animations, it is useful if you want to resume the animation in the middle of a loop. Also it is necessary to avoid losing synchronization in the sync option.sti2.mp4
state_machine_improvement_demo.zip