Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve description of GetNodeOrDefault in C# API #71168

Merged
merged 1 commit into from
Jan 11, 2023

Conversation

guilleatm
Copy link
Contributor

@guilleatm guilleatm commented Jan 10, 2023

@guilleatm
Copy link
Contributor Author

PR from issue in docs: godotengine/godot-docs#6577

Provided same text as GDScript version: https://docs.godotengine.org/en/latest/classes/class_node.html#class-node-method-get-node-or-null

First PR :)

@YuriSizov YuriSizov added this to the 4.x milestone Jan 10, 2023
@YuriSizov YuriSizov changed the title Mistake in generic GetNodeOrDefault description for C#. Improve description of GetNodeOrDefault in C# API Jan 10, 2023
@YuriSizov
Copy link
Contributor

Note that you will need to squash your commits into one, with a clear but short message, before this can be merged. You can do it later, in case there are some review comments that you need to address, but you will have to do this eventually. For a reference when crafting a good commit message you can read this.

@guilleatm
Copy link
Contributor Author

Squash done

Indenting with spaces and added a line break

Co-authored-by: Raul Santos <[email protected]>
@YuriSizov YuriSizov modified the milestones: 4.x, 4.0 Jan 11, 2023
@YuriSizov YuriSizov merged commit f73cb4c into godotengine:master Jan 11, 2023
@YuriSizov
Copy link
Contributor

Thanks! And congratulations on getting your first PR merged :)

@guilleatm
Copy link
Contributor Author

Thanks! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mistake on generic GetNodeOrNull() description.
3 participants