Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option in SCons to clone env variables #70770

Merged
merged 1 commit into from
Dec 16, 2023

Conversation

vnen
Copy link
Member

@vnen vnen commented Dec 31, 2022

This allows custom environment variables to be used during the build, which is useful when using alternative compilation tools such as caches and distributed build systems.

I've been using this locally for a while and it would be nice to have it upstream.

@vnen vnen requested a review from a team as a code owner December 31, 2022 14:04
@Chaosus Chaosus added this to the 4.0 milestone Jan 1, 2023
@YuriSizov YuriSizov modified the milestones: 4.0, 4.1 Feb 10, 2023
@YuriSizov YuriSizov modified the milestones: 4.1, 4.2 Jun 14, 2023
@AThousandShips AThousandShips modified the milestones: 4.2, 4.3 Oct 26, 2023
Copy link
Member

@akien-mga akien-mga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The feature and implementation make sense. Left some nitpicks, not blocking.

SConstruct Outdated Show resolved Hide resolved
This allows custom environment variables to be used during the build,
which is useful when using alternative compilation tools such as caches
and distributed build systems.
@vnen
Copy link
Member Author

vnen commented Dec 15, 2023

Renamed the option to import_env_vars.

Copy link
Member

@adamscott adamscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems OK, especially with the new name!

@YuriSizov YuriSizov merged commit e7a1eae into godotengine:master Dec 16, 2023
15 checks passed
@YuriSizov
Copy link
Contributor

Thanks!

@vnen vnen deleted the scons-clone-env-vars branch January 2, 2024 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants