C#: Synchronize Color with Core #69867
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raulsntos
commented
Dec 10, 2022
| @@ -597,7 +643,7 @@ public Color(string code, float alpha) | |||
| /// <exception name="ArgumentOutOfRangeException"> | |||
| /// <paramref name="rgba"/> color code is invalid. | |||
| /// </exception> | |||
| private static Color FromHTML(ReadOnlySpan<char> rgba) | |||
| public static Color FromHTML(ReadOnlySpan<char> rgba) | |||
There was a problem hiding this comment.
We may want to also implement an overload that takes String for .NET languages that don't support Spans (I think F# supports them, so it's probably only VB).
There was a problem hiding this comment.
Why don't they support spans? And not even for casting from a string?
There was a problem hiding this comment.
Because, AFAIK, VB doesn't support ref structs so the method can't be called.
raulsntos
force-pushed
the
dotnet/color
branch
from
a9b532b
to
c046f53
Compare
- Add `Luminance` readonly property. - Add `LinearToSrgb` and `SrgbToLinear` static methods. - Add `FromOkHsl` static method. - Add `FromRgbe9995` static method. - Add `FromString` static method. - Expose `FromHtml` static method. - Expose `HtmlIsValid` static method. - Add and update some Color documentation.
raulsntos
force-pushed
the
dotnet/color
branch
from
c046f53
to
d843a7a
Compare
|
Removed |
neikeq
approved these changes
Dec 16, 2022
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Luminancereadonly property.LinearToSrgbandSrgbToLinearstatic methods.to_linear()andto_srgb()to scripting #59456.FromOkHslstatic method.FromRgbe9995static method.FromStringstatic method.FromHtmlstatic method.HtmlIsValidstatic method.