Implement and expose OS.shell_show_in_file_manager()

[Daylily-Zeleen]

Implement 'OS::shell_show_in_file_manager()' for FilesystemDock and expose to GDScript.

Currently only implement for Windows, because I only have a windows device.
On other platforms, it will fallback to origin action.

I hope someone can implement for other platforms.

QQ.20220916183403.mp4

Replace #67071.

Fixed #64568.

[KoBeWi]

I investigated the focus issue I mentioned before and it's caused by the editor. If the editor window is not focused while the command is executed, the folder correctly opens in front instead in background.

[kleonc]

Does this PR fix #64568?

[Daylily-Zeleen]

Does this PR fix #64568?

Now fixed.

Fix.mp4

[kleonc]

Not sure if p_open_folder parameter is needed, in the codebase it seems we always do want to open the folder. But it might be nice to have it exposed even if it's not used internally. Fine for me.

[kleonc]

Note that in such case the menu entry is "Open in File Manager", it's expected to open the folder instead of just showing it:
https://github.com/godotengine/godot/blob/0e7c98061856a171838f4ae41e2ca925158e24aa/editor/filesystem_dock.cpp#L2604

I don't think it needs to be changed.

Suggested change

	if (fpath == "res://") {
	// This case means that right click at the spcace area in FilesystemDock.
	// Enter resource folder directly.
	OS::get_singleton()->shell_show_in_explorer(dir, true);
	} else {
	OS::get_singleton()->shell_show_in_explorer(dir, false);
	}
	OS::get_singleton()->shell_show_in_explorer(dir, true);

[kleonc]

Fixed #64568.

Only the Windows part? There also #64568 (comment) in there (could be done later/separately, asking just for confirmation).

[Daylily-Zeleen]

Fixed #64568.

Only the Windows part? There also #64568 (comment) in there (could be done later/separately, asking just for confirmation).

Yes, I have not linux device, I can't be responsible for that。

[bruvzg]

Only the Windows part? There also #64568 (comment) in there (could be done later/separately, asking just for confirmation).

Also, macOS version for the reference - #65890 (comment)

[YeldhamDev]

Wouldn't be better for the function's name to be shell_show_in_file_manager() instead? Since the editor references it as "File Manager", and it less vague/Windows-centric than just "explorer" (and yes, I know this PR only implements it for Windows for now, but I'm quite sure other OSes will be added by others in the future).

[Daylily-Zeleen]

I tested this PR again and the problem with folder opening in background seems to be gone.

There is however another issue. When you right-click a file, "Show in File Manager" option shows. When you click it, it opens the containing folder and selects the file -> this is correct When you right-click a folder, "Open in File Manager" option shows. When you click it, it does the same as if it was file -> this is wrong.

"Open in File Manager" should open the folder, not the parent folder.

EDIT: Seems like kleonc already commented about it.

@KoBeWi @kleonc I noticed that my implement is the same as the VSCode's behavior of "show in file manager". However, UE editor's behavior is the same as your description.
It seems this different is not important, right?
But if your are sure to enter a folder directly is better, I will modify my code. Please give me a definite reply.

[KoBeWi]

Well, the option does say "Open in File Explorer" when you right-click directory. It has different text. So either it should be made the same or maybe both could be available.

But IMO it's better to keep the current behavior, i.e. opening the folder. Selecting a folder is much less common operation and also makes it impossible to navigate to empty folders.

[Daylily-Zeleen]

Well, the option does say "Open in File Explorer" when you right-click directory. It has different text. So either it should be made the same or maybe both could be available.

But IMO it's better to keep the current behavior, i.e. opening the folder. Selecting a folder is much less common operation and also makes it impossible to navigate to empty folders.

I approve your opinion, my editor local language put the verb at the end of this option, and I never noticed the diffrenet between right-click file and folder.
Now I have changed the logic to open folder directly.

[YeldhamDev]

The commit message should be changed to reflect the function's current name.

[akien-mga]

Thanks!