Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix animation blending for value track UPDATE_DISCRETE and UPDATE_TRIGGER mode #68993

Merged

Conversation

TokageItLab
Copy link
Member

@TokageItLab TokageItLab commented Nov 22, 2022

Fixes #68261.

UPDATE_DISCRETE and UPDATE_TRIGGER do not blend values, but set values to objects on the fly, but this will be overwritten by the blended values.

This PR prevents overwriting by skipping the normal process of applying blend values if the blend contains UPDATE_DISCRETE or UPDATE_TRIGGER tracks. For blending, INTERPOLATION_NEAREST should be used instead. I will update the documentation about the blending later.

@TokageItLab TokageItLab added this to the 4.0 milestone Nov 22, 2022
@TokageItLab TokageItLab requested a review from a team as a code owner November 22, 2022 06:50
@TokageItLab TokageItLab changed the title Fix animation blending for value track DISCRETE/TRIGGER mode Fix animation blending for value track UPDATE_DISCRETE and UPDATE_TRIGGER mode Nov 22, 2022
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UPDATE_DISCRETE & UPDATE_TRIGGER aren't blended correctly
2 participants