Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Web] Fix shutdown, force WebGL2, fix editor run args. #68292

Merged
merged 3 commits into from
Nov 5, 2022
Merged

[Web] Fix shutdown, force WebGL2, fix editor run args. #68292

merged 3 commits into from
Nov 5, 2022

Conversation

Faless
Copy link
Collaborator

@Faless Faless commented Nov 5, 2022

Web Editor now works, can launch games.

@Faless Faless added this to the 4.0 milestone Nov 5, 2022
@Faless
Copy link
Collaborator Author

Faless commented Nov 5, 2022 •
edited
Loading

Note, I built with emcc 3.1.18 because newer emscripten removed a system library (sys/timex.h) causing build failure on a third-party library (basis_universal, EDIT: which seems fixed upstream BinomialLLC/basis_universal#328).

clayjohn
clayjohn approved these changes Nov 5, 2022
View reviewed changes
Copy link
Member

@clayjohn clayjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WebGL initialization stuff looks correct to me. I'm not qualified to have an opinion on the rest though.

@akien-mga akien-mga merged commit 13f1d80 into godotengine:master Nov 5, 2022
@akien-mga
Copy link
Member

Thanks!

@Faless Faless deleted the web/4.x_editor_fixes branch November 5, 2022 21:32
@dsnopek dsnopek mentioned this pull request Nov 10, 2022
Merged
@Faless Faless mentioned this pull request Nov 26, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clayjohn clayjohn clayjohn approved these changes

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
bug platform:web topic:editor topic:porting
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Faless @akien-mga @clayjohn