Fix scrolling behavior with zero/low page value #67910
Merged
+8
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calinou
added
cherrypick:3.x
KoBeWi
approved these changes
Mar 7, 2023
|
Thanks! |
|
Cherry-picked for 4.0.2. |
akien-mga
changed the title
|
Cherry-picked for 3.6. |
akien-mga
removed
the
cherrypick:3.x
|
Cherry-picked for 3.5.3. |
akien-mga
removed
the
cherrypick:3.5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ScrollBar with page set to 0 ignores mouse wheel events and clicks. Only dragging can change its value. Also combination of small page value and big step can produce unpredicted results.
I think it's not the best behaviour and probably disabling mouse input by setting page to 0 is not intentional.
I propose to change value by some percent for mouse events when page is set to default 0.
Scrolling before and afer:
Test project:
scrollbarchange.zip