-
-
Notifications
You must be signed in to change notification settings - Fork 21.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove error condition from get_global_transform() #67710
Remove error condition from get_global_transform() #67710
Conversation
This change makes sense to me. Don't see any problems with the implementation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense to me.
@mhilbrunner |
Thanks! |
Cherry-picked for 3.6. |
Just seen this has been cherry picked! Yay, had been waiting for this for a while (see #30445 ) . Ah, I've just seen, this PR is for canvas item, and the issue is for Also a possible bug - I haven't checked whether this occurs yet. If you remove a branch from the scene tree then unless the global transform is made dirty then the results will be stale (i.e. still represent the transform within the tree). So when removing from the tree we would need to propagate dirty flags to ensure consistent result. I'm not sure if this is done already, will check. EDIT: The |
Removes the arbitrary error in
get_global_transform()
method.The error makes no sense for a couple of reasons:
Node
ancestors stop transform propagationnull
parent, which is effectively the same as havingNode
parentCloses #30445