Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.x] Add double_tap attribute to InputEventScreenTouch #67607

Merged

Conversation

m4gr3d
Copy link
Contributor

@m4gr3d m4gr3d commented Oct 19, 2022

This provides parity with the InputEventMouseButton allowing for proper conversion between the two events.

Address #67033

master version

@RandomShaper
Copy link
Member

I'm testing it at the moment. I'm doing a few changes to have it working 100% correctly. Sadly, run out of time today. Tomorrow I'll report.

@RandomShaper
Copy link
Member

These are the changes I'd like to suggest:
patch.txt

Without them, the timing of some down/up events is wrong and also the second tap in a double tap could get stuck.

Besides that, the only concern would be that the new double_tap field is not filled reliable across all the platforms, but that could be addressed separately.

@m4gr3d
Copy link
Contributor Author

m4gr3d commented Oct 20, 2022

These are the changes I'd like to suggest: patch.txt

Without them, the timing of some down/up events is wrong and also the second tap in a double tap could get stuck.

Besides that, the only concern would be that the new double_tap field is not filled reliable across all the platforms, but that could be addressed separately.

@RandomShaper The patch looks good! I'll apply it and update the PR.

This provides parity with the `InputEventMouseButton` allowing for proper conversion between the two events.
@m4gr3d m4gr3d force-pushed the input_event_screen_touch_double_tap_3x branch from 47b0946 to be4b07c Compare October 20, 2022 18:56
@m4gr3d
Copy link
Contributor Author

m4gr3d commented Oct 20, 2022

@RandomShaper Updated! Can you review the changes. If this looks good, I'll forward-port the changes to the master branch.

@m4gr3d m4gr3d changed the title Add double_tap attribute to InputEventScreenTouch [3.x] Add double_tap attribute to InputEventScreenTouch Oct 20, 2022
@m4gr3d m4gr3d merged commit 33b80bd into godotengine:3.x Oct 22, 2022
@m4gr3d m4gr3d deleted the input_event_screen_touch_double_tap_3x branch October 22, 2022 14:37
@akien-mga akien-mga added the bug label Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants