Add a way to store additional data in GLTFState and GLTFNode #67428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fire
reviewed
Oct 15, 2022
fire
reviewed
Oct 15, 2022
fire
reviewed
Oct 15, 2022
aaronfranke
force-pushed
the
gltf-additional-data
branch
from
963918e
to
a70dce8
Compare
fire
approved these changes
Oct 15, 2022
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a subset of #66026 for easier reviewing.
This PR allows GLTFDocumentExtension classes to be stateless by adding a way to store additional data in GLTFState and GLTFNode. This uses a Dictionary internally, with each GLTFDocumentExtension class storing arbitrary data with their name as the key. Therefore, it's only exposed via wrapper methods to ensure the API is used correctly.
This work was sponsored by The Mirror.