-
-
Notifications
You must be signed in to change notification settings - Fork 21.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose and warn about Node Filters in Scene Tree Dock #65932
Expose and warn about Node Filters in Scene Tree Dock #65932
Conversation
Looks good, but the warning system is weird that it shows a warning icon but the actual warning is shown in the menu. That's not something we do anywhere else in the editor. The warning should be shown in a tooltip on hover of the warning icon, like for node configuration warnings. |
Not sure it would be possible to have the tooltip display exactly there, without resulting into something poor and hacky. I want to note that the Warning icon in this PR is actually still the "clear" TextEdit button. Its behavior remains unchanged, which means it would clear the text on click instead of telling the user what's wrong. Not the worst thing in the world, really, just putting it out there. |
7495077
to
95074fc
Compare
All good now, I hope. |
95074fc
to
0554f5c
Compare
Thank you for the testing as always, @KoBeWi. The group thing may not be related to this PR, but it'd still be nice to see if something can be done about it, because I implemented the feature and it'd be nice to address it. It may be related to the way groups are detected. Unfortunately it has to be a bit finnicky already because Groups don't seem to distinguish between internal and exposed. It'd love to take a look at that project you're testing it with to spot the issue. Meanwhile, I addressed the right-click options not working. |
"Exposed" groups have |
Ok I can address it in another PR. Perhaps within #65939 to make it quick. |
0554f5c
to
b4d5181
Compare
Adds "Filter by Type" and "Filter by Group" in the Scene Tree Dock's MenuButton. Hovering on them displays an useful tooltip. When selecting these items, the matching parameter is appended to the terms, and the caret is automatically brought to the end. When typing a filter that cannot be identified, a warning icon is displayed. The reason is explained as a tooltip. The same options are also quickly available by right-clicking or middle-clicking in the text field.
b4d5181
to
33092b6
Compare
Thanks! |
Continuation of #65352. (see also #65352 (review))
This PR adds "Filter by Type" and "Filter by Group" in the Scene Tree Dock's MenuButton (the one on the top right featuring 3 dots), exposing them to everyone that doesn't religiously look at this engine's source code.
And lastly, the same options are also quickly available by right-clicking or middle-clicking in the text field.