Fix RestFixer for the model has Skin which non-inverse-global-rest
#65278
+205
−145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TokageItLab
force-pushed
the
fix-node-transform-skin
branch
from
49acb01
to
e74e402
Compare
fire
reviewed
Sep 3, 2022
TokageItLab
force-pushed
the
fix-node-transform-skin
branch
from
e74e402
to
d9350ee
Compare
|
Replaced some checks with ERR_CONTINUE macro and reduced nesting. |
TokageItLab
force-pushed
the
fix-node-transform-skin
branch
from
d9350ee
to
be316f7
Compare
fire
reviewed
Sep 3, 2022
TokageItLab
force-pushed
the
fix-node-transform-skin
branch
from
be316f7
to
563dcbe
Compare
|
I plan to try a few more models and report back. |
fire
approved these changes
Sep 4, 2022
|
Tested the whole retargeting workflow.
|
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, RestFixer forced Skin to re-bind to non-inverse-global-rest and did not take into account the original bound Pose.
This PR takes the original bound Pose into account in the re-binding calculations.
Before (broken):
After:
Test model
Siren Head Monkey Run / CC by The Pre Alpha Man
https://sketchfab.com/3d-models/siren-head-monkey-run-2654e635af28463f86f71f9720b914e6