Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CarouselButton Node #64448

Merged
merged 0 commits into from
Aug 17, 2022
Merged

Add CarouselButton Node #64448

merged 0 commits into from
Aug 17, 2022

Conversation

AlaraBread
Copy link

@AlaraBread AlaraBread commented Aug 15, 2022

implements godotengine/godot-proposals#5139

edit

opened a new pr because this one was on my master branch: #64535

@YuriSizov
Copy link
Contributor

You shouldn't use your master branch for PRs. You should start a new branch from your master and work there. You now have unrelated changes in your submission.

@AlaraBread
Copy link
Author

You shouldn't use your master branch for PRs. You should start a new branch from your master and work there. You now have unrelated changes in your submission.

should i make a new pr? or is there a way I can change this one? sorry, im new to this.

@YuriSizov
Copy link
Contributor

should i make a new pr? or is there a way I can change this one? sorry, im new to this.

I'm not sure what is wrong with your current branch and why another commit is appended to it. You can probably still fix it with a correct rebase, but it would be harder to do on your fork's master.

At the very least, consider that in future PRs. But for now, you have to fix the commits to only include your changes. If you want to open a new PR for that, go ahead, we'll just close this one.

@AlaraBread AlaraBread force-pushed the master branch 2 times, most recently from 7f73718 to 7d9f319 Compare August 15, 2022 21:52
@AlaraBread
Copy link
Author

okay, i fixed some errors that i was getting, and removed your commit.

@AlaraBread AlaraBread force-pushed the master branch 3 times, most recently from b0a4e37 to 4820d63 Compare August 16, 2022 17:19
@AlaraBread
Copy link
Author

fixed a few edge cases

@AlaraBread
Copy link
Author

here's a video of the CarouselButton

2022-08-15_13-11-39.mp4

@AlaraBread
Copy link
Author

opened a new pr with a branch that isn't my master branch: #64535

@YuriSizov YuriSizov removed this from the 4.x milestone Aug 17, 2022
@YuriSizov
Copy link
Contributor

For the record, this was NOT merged. The user just restored their master to a pristine state, so this PR no longer contained any commits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants