-
-
Notifications
You must be signed in to change notification settings - Fork 21.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CarouselButton Node #64448
Add CarouselButton Node #64448
Conversation
You shouldn't use your |
should i make a new pr? or is there a way I can change this one? sorry, im new to this. |
I'm not sure what is wrong with your current branch and why another commit is appended to it. You can probably still fix it with a correct rebase, but it would be harder to do on your fork's At the very least, consider that in future PRs. But for now, you have to fix the commits to only include your changes. If you want to open a new PR for that, go ahead, we'll just close this one. |
7f73718
to
7d9f319
Compare
okay, i fixed some errors that i was getting, and removed your commit. |
b0a4e37
to
4820d63
Compare
fixed a few edge cases |
here's a video of the CarouselButton 2022-08-15_13-11-39.mp4 |
opened a new pr with a branch that isn't my master branch: #64535 |
For the record, this was NOT merged. The user just restored their master to a pristine state, so this PR no longer contained any commits. |
implements godotengine/godot-proposals#5139
edit
opened a new pr because this one was on my master branch: #64535