Add dumb theme item cache to Control
#64314
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've experimented with this a year ago, and in targeted testing it didn't yield any meaningful performance improvements. But there seems to be a benefit to it still in some extreme situations, like mentioned in #64241. So I'm reviving it, as it shouldn't have any downsides and would be beneficial for cases that abuse theme item fetching without a cache on the user side.
Out of curiosity, I've retested the snippet from #64271 (review) again, and got a huge boost, on top of the caching added by @KoBeWi in that PR. From
~5.4s
down to~4.3s
in debug builds! There are clearly caches missing in some of the editor log controls. Likely,RichTextLabel
is doing something nasty.This can be backported to
3.x
, adjusted for the code structure there.cc @AaronRecord since you're interested in optimizing theme.