Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add enabled module names to the list of supported features for the project manager #63132

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

aaronfranke
Copy link
Member

@aaronfranke aaronfranke commented Jul 17, 2022

This PR enhances the project feature warning system in the project manager by listing all enabled modules as supported features. This allows people to manually list required modules in their projects, and does not require Godot to know about those modules at all - Godot only knows that the project asks for XYZ and it's missing.

As an example, I tested a project with this text in project.godot:

config/features=PackedStringArray("4.0", "GDScript", "WebP", "WebXR", "Voxel")

And this is what shows up in the project manager of Godot compiled with WebXR disabled:

Screen Shot 2022-07-17 at 6 05 04 PM

4.0, GDScript, and WebP are all supported, so they are not warned about. WebXR is disabled, and Voxel is not present, so they're not in the supported features list, and the project manager warns about them.

@Calinou
Copy link
Member

Calinou commented Jul 18, 2022

Should the warning test in the project text have a "Missing modules:" prefix (or "Missing:" if there isn't enough space)?

@aaronfranke
Copy link
Member Author

@Calinou The system doesn't make the distinction of whether a feature is a module or not. It's purposefully simple, just a list of strings. The strings can be modules, or they could be other features, or engine versions.

@akien-mga
Copy link
Member

akien-mga commented Jul 18, 2022

The code for this is mostly simple, but it does require adding a new method to each module's config.py. We could use the folder names, but since these names are displayed to the user, I think nicer names are better.

I would use the folder name to keep it simple, and pass it through EditorPropertyNamesProcessor for prettification.

@aaronfranke

This comment was marked as resolved.

@akien-mga
Copy link
Member

CC @timothyqiu

@timothyqiu

This comment was marked as resolved.

@aaronfranke aaronfranke force-pushed the module-names branch 2 times, most recently from 330b6b8 to 446dc39 Compare July 18, 2022 20:14
@aaronfranke
Copy link
Member Author

aaronfranke commented Jul 18, 2022

@timothyqiu Thanks, indeed that fixed it. I updated this PR.

@aaronfranke aaronfranke modified the milestones: 4.0, 4.x Jan 30, 2023
@aaronfranke aaronfranke force-pushed the module-names branch 2 times, most recently from d4e725a to 7613890 Compare February 21, 2023 02:29
@aaronfranke aaronfranke force-pushed the module-names branch 2 times, most recently from 953f92a to 845dbe8 Compare March 27, 2024 03:40
@AThousandShips AThousandShips removed request for a team May 25, 2024 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants