-
-
Notifications
You must be signed in to change notification settings - Fork 21.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add enabled module names to the list of supported features for the project manager #63132
base: master
Are you sure you want to change the base?
Conversation
Should the warning test in the project text have a "Missing modules:" prefix (or "Missing:" if there isn't enough space)? |
@Calinou The system doesn't make the distinction of whether a feature is a module or not. It's purposefully simple, just a list of strings. The strings can be modules, or they could be other features, or engine versions. |
I would use the folder name to keep it simple, and pass it through EditorPropertyNamesProcessor for prettification. |
This comment was marked as resolved.
This comment was marked as resolved.
CC @timothyqiu |
This comment was marked as resolved.
This comment was marked as resolved.
330b6b8
to
446dc39
Compare
@timothyqiu Thanks, indeed that fixed it. I updated this PR. |
56c53d4
to
a3e1142
Compare
a3e1142
to
7965059
Compare
7965059
to
b43368f
Compare
d4e725a
to
7613890
Compare
7613890
to
559b05f
Compare
559b05f
to
1d62b48
Compare
1d62b48
to
25f2974
Compare
25f2974
to
703904f
Compare
703904f
to
fb7e6cf
Compare
fb7e6cf
to
41b7eb4
Compare
41b7eb4
to
ca3973f
Compare
953f92a
to
845dbe8
Compare
ad35644
to
3041aca
Compare
3041aca
to
1d99478
Compare
1d99478
to
84d66a0
Compare
84d66a0
to
fcc7d6e
Compare
This PR enhances the project feature warning system in the project manager by listing all enabled modules as supported features. This allows people to manually list required modules in their projects, and does not require Godot to know about those modules at all - Godot only knows that the project asks for XYZ and it's missing.
As an example, I tested a project with this text in
project.godot
:And this is what shows up in the project manager of Godot compiled with WebXR disabled:
4.0, GDScript, and WebP are all supported, so they are not warned about. WebXR is disabled, and Voxel is not present, so they're not in the supported features list, and the project manager warns about them.