Input: Re-enable input accumulation disabled by error in 3.4 #62826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Input accumulation was implemented and enabled by default in 3.1, and I don't recall major complaints around it (or bugs were fixed). In 3.4, godotengine#42220 added input buffering and apparently toggled input accumulation off by mistake. This led to multiple bug reports about degraded performance on Windows, or simply unexpected behavior change (see linked issues in godotengine#55037). Fixes godotengine#55037.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Input accumulation was implemented and enabled by default in 3.1, and
I don't recall major complaints around it (or bugs were fixed).
In 3.4, #42220 added input buffering and apparently toggled input
accumulation off by mistake.
This led to multiple bug reports about degraded performance on Windows,
or simply unexpected behavior change (see linked issues in #55037).
Fixes #55037.
We don't plan to cherry-pick this to
3.4as this branch has been in use for too long already with input accumulation disabled, and this would be a breaking change unexpected in a patch release.For
3.5, we should point out this change clearly in the changelog so that users who need the precision of disabled input accumulation know to change it back when upgrading.