Add multi window code and shader editors (GSOC'22 Project) #62378

trollodel · 2022-06-24T14:00:45Z

This is the main PR for my GSOC'22 project (link to the project description).
Old commit history with expanded commits: https://github.com/trollodel/godot/tree/gsoc_2022_multiwindow_full_history

The project consists in the following major features:

Script Editor undocking.
Shader Editor undocking.
Window layout saves.

You can read more about it in the GSOC'22 progress report: https://godotengine.org/article/gsoc-2022-progress-report-1

The PR is feature complete, further enhancement will be done in a separate PR, after the merge of this one, which will happen after the 4.0 release as marked by the milestone.

Screenshots/Videos

Peek.24-06-2022.12-06.mp4

Peek.15-07-2022.12-42.mp4

Peek.15-07-2022.13-39.mp4

Peek.19-07-2022.15-06.mp4

The screen selector in the Script Editor (two 1920x1080 screen)

The screen selector with different screen sizes (one 1920x1080 screen and one 1280x960 screen, 4:3 aspect ratio)

Everything undocked!

Part of godotengine/godot-proposals#28.

Happy testing!

Supersedes #62963.

Keywords for easy searching: detach script, detachable, detached, pop out, popping out, other window, separate window, undock, undocked, undockable, floating

jcostello · 2022-06-24T14:20:29Z

Looking good so far. As I mention in the other PR discussion: F1 is not working inside the code window while its focus

trollodel · 2022-07-06T12:38:25Z

@jcostello sorry for the late response, but now global shortcuts (like F1 or Ctrl+S) should work in the script window too.

jcostello · 2022-07-06T13:47:00Z

@jcostello sorry for the late response, but now global shortcuts (like F1 or Ctrl+S) should work in the script window too.

Nice. Im out til the weekend. I will test it then :)

trollodel · 2022-08-18T18:30:45Z

The PR is now feature complete for what I have planned. The only thing remaining to do are a bunch of editor settings to customize the behavior.
Some commits done here will be extracted in dedicated PRs as they are independent, but required, changes.
To indicate the progresses, I'll mark the PR as ready for review, even if it's not ready to be merged (starting from the verbose commit history).

Again, Happy testing!

YeldhamDev · 2022-08-18T18:57:21Z

Could you please rebase this to the latest master commit if possible? If it's too much for the quantity of commits in the PR then ignore this.

YeldhamDev · 2022-08-19T15:58:36Z

Icons in the "Search Help" dialog appear to be broken:

trollodel · 2023-05-05T12:21:22Z

I found out why the screen popup doesn't do anything, but I don't know what causes it .-. The buttons do not emit the pressed signal. It's as if they don't receive clicks. It might be because you're abusing OptionButton's popup for that instead of a custom one, but not sure why would it make difference, so maybe it's not that. But the buttons are unclickable. Which is weird, because you said it works for you.

I did some testing regarding the screen popup issue. The buttons don't receive pressed mouse events. Seems like a problem exclusive to PopupMenu. I guess using MenuButton this way is wrong. So instead ScreenSelect should be a regular Button with a custom PopupPanel.

Ok now it uses regular Button and Popup, It should work for you now.

trollodel · 2023-05-07T09:35:13Z

The popup is now functional. The only problem is that it doesn't close once clicked upside_down_face

I can't reproduce it on Linux. Just in case, I forcefully hide the popup when the button is pressed.

The F1 shortcut is still broken. It needs to be fixed.

After the rebase, the F1 shortcuts now work when docked and undocked.

Also there are some conflicts, so the PR needs rebase.

Done.

editor/editor_node.cpp

KoBeWi · 2023-05-09T12:46:40Z

I found an edge case. When you make docks floating and restart editor in single mode, the docks will be unusable:

Not critical though.

KoBeWi

All obvious/important issues are fixed.

akien-mga

Looks good to me from a cursory code check, and I tested the functionality a bit and it seems to work well.

I think it's time for a merge and get it tested more widely :)

For the record, I'll release 4.1-dev2 tomorrow but I already built it from a commit prior to merging this, so this will be in an official build in 4.1-dev3.

akien-mga · 2023-05-09T17:27:24Z

I noticed this warning in the terminal output (and in the editor toaster) while opening a project:

Warning emitted when opening any project: "Attempting to access theme items too early; prefer NOTIFICATION_POSTINITIALIZE and NOTIFICATION_THEME_CHANGED"

I previously ran into it with #76509 which was fixed by #76513. This PR might introduce another case of using the theme too early.

As a side note, while testing this PR I saved a project with 2 floating docks, which were properly remembered across sessions. Then I reopened that same project in a Godot build from the master branch without this PR, and the floating docks were still floating and functional. Pretty cool feature that works retroactively :P

editor/window_wrapper.cpp

trollodel · 2023-05-09T18:06:29Z

For the record, I'll release 4.1-dev2 tomorrow but I already built it from a commit prior to merging this, so this will be in an official build in 4.1-dev3.

So sad, users won't have this absolutely desired feature tomorrow, they would wait for other 2 weeks (sarcasm).

As a side note, while testing this PR I saved a project with 2 floating docks, which were properly remembered across sessions. Then I reopened that same project in a Godot build from the master branch without this PR, and the floating docks were still floating and functional. Pretty cool feature that works retroactively :P

I tested myself and I don't really understand why it works. I guess the docks were placed in the default slot as a failsafe.

AThousandShips · 2023-05-09T19:46:54Z

CI should be fixed by #76885, will have to be rebased when it is merged

akien-mga · 2023-05-10T10:49:21Z

Congrats on landing this amazing feature! 🎉
Thanks for your patience with the review and release processes :)

trollodel mentioned this pull request Jun 24, 2022

Implement Floating Script Editor Window #62373

Closed

Chaosus added enhancement topic:editor labels Jun 24, 2022

Chaosus added this to the 4.0 milestone Jun 24, 2022

Calinou modified the milestones: 4.0, 4.1 Jun 24, 2022

Calinou added the usability label Jun 24, 2022

trollodel force-pushed the gsoc_2022_multiwindow branch from 882f18a to 174039e Compare July 6, 2022 12:32

trollodel force-pushed the gsoc_2022_multiwindow branch 4 times, most recently from 9994552 to 3622226 Compare July 19, 2022 14:03

trollodel force-pushed the gsoc_2022_multiwindow branch 4 times, most recently from b6c7fbe to 7296303 Compare August 3, 2022 14:54

trollodel force-pushed the gsoc_2022_multiwindow branch 2 times, most recently from 35443f7 to d73a49e Compare August 18, 2022 08:44

trollodel marked this pull request as ready for review August 18, 2022 18:30

trollodel requested review from a team as code owners August 18, 2022 18:30

trollodel force-pushed the gsoc_2022_multiwindow branch from 2697ed2 to aa02bca Compare August 18, 2022 19:00

This comment was marked as resolved.

Sign in to view

trollodel force-pushed the gsoc_2022_multiwindow branch from b740649 to bfb1a37 Compare May 7, 2023 09:29

KoBeWi reviewed May 7, 2023

View reviewed changes

editor/editor_node.cpp Show resolved Hide resolved

trollodel force-pushed the gsoc_2022_multiwindow branch from bfb1a37 to d89f90d Compare May 9, 2023 07:30

KoBeWi reviewed May 9, 2023

View reviewed changes

editor/editor_node.cpp Outdated Show resolved Hide resolved

KoBeWi approved these changes May 9, 2023

View reviewed changes

akien-mga approved these changes May 9, 2023

View reviewed changes

KoBeWi reviewed May 9, 2023

View reviewed changes

editor/window_wrapper.cpp Outdated Show resolved Hide resolved

trollodel force-pushed the gsoc_2022_multiwindow branch from d89f90d to 590960a Compare May 9, 2023 17:45

Add multi window code and shader editors

b4d6b47

trollodel force-pushed the gsoc_2022_multiwindow branch from 590960a to b4d6b47 Compare May 10, 2023 08:43

akien-mga merged commit 31fc7a8 into godotengine:master May 10, 2023

trollodel deleted the gsoc_2022_multiwindow branch May 10, 2023 11:04

mrbbbaixue mentioned this pull request May 10, 2023

wish this was a built in feature LaoDie1/godot-float-script-editor#11

Open

Anutrix mentioned this pull request May 10, 2023

Obsolete 2D, 3D, Script, Assetlib and MainWindow in favor of dockable tabs like Unity Engine godotengine/godot-proposals#1890

Open

AnidemDex mentioned this pull request May 10, 2023

Add ability to detach the timeline editor window AnidemDex/Blockflow#24

Open

Sauermann mentioned this pull request May 10, 2023

Propagate shortcut events to SubViewports #76926

Merged

aaronfranke mentioned this pull request May 12, 2023

Add support for multiple displays/screens/monitors in Godot editor godotengine/godot-proposals#28

Open

winston-yallow mentioned this pull request May 25, 2023

Script Editor: Allow displaying Scripts and Docs as tabs above the Text Editor, akin to other IDEs godotengine/godot-proposals#4081

Open

trollodel mentioned this pull request Jun 16, 2023

Fix placement and style of the "Make Floating" button #78350

Merged

Sauermann mentioned this pull request Jul 19, 2023

Floating Editor Dock unusable in Single Window Mode #79673

Closed

trollodel mentioned this pull request Jul 22, 2023

Make the single window mode check more strict #79793

Merged

trollodel mentioned this pull request Dec 7, 2023

Extract EditorDockManager from EditorNode #84193

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add multi window code and shader editors (GSOC'22 Project) #62378

Add multi window code and shader editors (GSOC'22 Project) #62378

trollodel commented Jun 24, 2022 •

edited by aaronfranke

Loading

jcostello commented Jun 24, 2022

trollodel commented Jul 6, 2022

jcostello commented Jul 6, 2022

trollodel commented Aug 18, 2022 •

edited

Loading

YeldhamDev commented Aug 18, 2022 •

edited

Loading

YeldhamDev commented Aug 19, 2022

trollodel commented May 5, 2023 •

edited

Loading

This comment was marked as resolved.

trollodel commented May 7, 2023 •

edited

Loading

KoBeWi commented May 9, 2023

KoBeWi left a comment

akien-mga left a comment

akien-mga commented May 9, 2023

trollodel commented May 9, 2023

AThousandShips commented May 9, 2023 •

edited

Loading

akien-mga commented May 10, 2023

Add multi window code and shader editors (GSOC'22 Project) #62378

Add multi window code and shader editors (GSOC'22 Project) #62378

Conversation

trollodel commented Jun 24, 2022 • edited by aaronfranke Loading

jcostello commented Jun 24, 2022

trollodel commented Jul 6, 2022

jcostello commented Jul 6, 2022

trollodel commented Aug 18, 2022 • edited Loading

YeldhamDev commented Aug 18, 2022 • edited Loading

YeldhamDev commented Aug 19, 2022

trollodel commented May 5, 2023 • edited Loading

This comment was marked as resolved.

trollodel commented May 7, 2023 • edited Loading

KoBeWi commented May 9, 2023

KoBeWi left a comment

Choose a reason for hiding this comment

akien-mga left a comment

Choose a reason for hiding this comment

akien-mga commented May 9, 2023

trollodel commented May 9, 2023

AThousandShips commented May 9, 2023 • edited Loading

akien-mga commented May 10, 2023

trollodel commented Jun 24, 2022 •

edited by aaronfranke

Loading

trollodel commented Aug 18, 2022 •

edited

Loading

YeldhamDev commented Aug 18, 2022 •

edited

Loading

trollodel commented May 5, 2023 •

edited

Loading

trollodel commented May 7, 2023 •

edited

Loading

AThousandShips commented May 9, 2023 •

edited

Loading