Simplify Subresource Saving #62318
Simplify Subresource Saving #62318
Conversation
|
Is it related to #62287? |
There was a problem hiding this comment.
I just tested it and this indeed fixes the bug and works well.
This implementation is quite smart, I remember while debugging that I also found out that ResourceCache::get_cached_resources(&cached); will also contain all sub resources but I didn't know how to proceed from there.
|
Seems like this PR causes changes to unopened scenes. When you have an instanced scene, but it's not opened in the editor, saving the parent scene will still save all instanced scenes.
So I guess it's the opposite 😅 |
|
@KoBeWi Strangely I don't see why that would be different than what it was before, but in either case I don't think applying this to PackedScenes makes any sense, so I could manually skip them? |
reduz
force-pushed
the
simplify-subresource-saving
branch
from
7952338
to
925e11c
Compare
Redo edited subresource (and resource) saving in a much more simplified way. I think this should work (unless I am missing something) and be faster than what is there. It should also supersede godotengine#55885. I am not 100% entirely convinced that this approach works, but I think it should so please test.
reduz
force-pushed
the
simplify-subresource-saving
branch
from
925e11c
to
9eb5f2a
Compare
|
@KoBeWi Please test again to see if you encounter the same behavior |
|
Thanks! |
akien-mga
added
the
cherrypick:3.x
|
Cherry-picked for 3.6. |
akien-mga
removed
the
cherrypick:3.x
Redo edited subresource (and resource) saving in a much more simplified way. It should be much faster too and help considerably improve save times on large scenes.
I think this should work (unless I am missing something) and be faster than what is there.
Fixes #55885 and supersedes #57077.
I am not 100% entirely convinced that this approach works. Everything points to the fact it should and it seems to work for me, but just in case make sure to test well!