Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.x] Tweak editor icons for navigation nodes and SkeletonIK #62246

Merged
merged 1 commit into from
Jun 20, 2022

Conversation

timothyqiu
Copy link
Member

@timothyqiu timothyqiu commented Jun 20, 2022

Backport of #62201

Updated snapshot in #62246 (comment)

@timothyqiu timothyqiu added this to the 3.5 milestone Jun 20, 2022
@timothyqiu timothyqiu requested a review from a team as a code owner June 20, 2022 13:36
@YuriSizov
Copy link
Contributor

A nitpick, but I think the colors are off and need to be less saturated for this version of Godot. You can clearly see the pink and the blue are different from their base node counterparts.

@Calinou
Copy link
Member

Calinou commented Jun 20, 2022

A nitpick, but I think the colors are off and need to be less saturated for this version of Godot. You can clearly see the pink and the blue are different from their base node counterparts.

Indeed, a 1:1 color match is also required for dark → light theme conversion to work.

@timothyqiu
Copy link
Member Author

TIL the tint colors are different between 4.0 and 3.x :) Adjusted the colors to be the same as their base icons:

Dark Light
dark light

@Calinou
Copy link
Member

Calinou commented Jun 20, 2022

TIL the tint colors are different between 4.0 and 3.x :) Adjusted the colors to be the same as their base icons:

For reference, this change was initially made in #48644. It wasn't remade for 3.x as we want the editor theme to be distinguishable between 3.x and 4.0 (so tutorials' version can be recognized instantly).

@akien-mga akien-mga merged commit 3fa7179 into godotengine:3.x Jun 20, 2022
@akien-mga
Copy link
Member

Thanks!

@timothyqiu timothyqiu deleted the icon-coloring branch June 20, 2022 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants