Skip to content

Conversation

@nathanfranke
Copy link

@nathanfranke nathanfranke commented Jun 12, 2022

Edit: Marked as draft since this needs maintainer approval.

Edit: Closing for two reasons:

  • Changing copyright should be discussed as an issue or Godot Improvement Proposal (GIP)
  • Public domain is not a worldwide solution to attribution; see Moral rights (wikipedia.org)

See also: #105358

If I'm not mistaken, every new Godot project (once distributed) is technically in violation of copyright because it does not attribute the copyright of icon.png. (True, but public domain doesn't necessarily help this)

Of course, we would need clear permission from the creator to do this change.

@Calinou Calinou added enhancement cherrypick:3.x Considered for cherry-picking into a future 3.x release cherrypick:3.5 Considered for cherry-picking into a future 3.5.x release labels Jun 12, 2022
@Calinou Calinou added this to the 4.0 milestone Jun 12, 2022
@LinuxUserGD
Copy link
Contributor

Of course, we'll need clear permission from the creator to do this change. I am not fully sure who that is, so I assumed it is the same creator who made the other icon variations.

See https://github.com/godotengine/godot/commits/master/LOGO_LICENSE.md

@timothyqiu
Copy link
Member

See also #51028 for an alternative approach.

@YuriSizov YuriSizov modified the milestones: 4.0, 4.1, 4.x Feb 10, 2023
@deralmas
Copy link
Contributor

deralmas commented Apr 5, 2023

Yeah #51028 sounds like the proper approach IMO, I have a feeling that making the project icon PD might not be the best idea.

@nathanfranke
Copy link
Author

I agree. I'm curious to see the best way to handle license compliance on non-command line platforms though.

@Calinou
Copy link
Member

Calinou commented Apr 5, 2023

I agree. I'm curious to see the best way to handle license compliance on non-command line platforms though.

See #51028 (comment).

@akien-mga akien-mga removed the cherrypick:3.5 Considered for cherry-picking into a future 3.5.x release label Aug 18, 2023
@nathanfranke
Copy link
Author

nathanfranke commented Mar 9, 2024

Edit: I made a tentative PR for this feature: #105358

#51028 definitely solves core problems in this area.

However, I think there is still a general legal concern here IINM:

  • Create new empty Godot Project (With icon.svg)
  • Upload to a public git repository
  • Now icon.svg is being redistributed without attribution

I think adding license information directly to icon.svg is a great solution:

<!-- Godot Engine logo. Copyright 2017, Andrea Calabró. Licensed under CC-BY-4.0. -->
<svg ...>

@deralmas
Copy link
Contributor

deralmas commented Mar 9, 2024

@nathanfranke great idea! Feel free to open a PR for that!

@nathanfranke nathanfranke marked this pull request as draft April 13, 2025 16:43
@nathanfranke nathanfranke deleted the icon-license branch April 13, 2025 16:43
@nathanfranke nathanfranke restored the icon-license branch April 13, 2025 16:44
@nathanfranke nathanfranke reopened this Apr 13, 2025
@AThousandShips AThousandShips added archived and removed cherrypick:3.x Considered for cherry-picking into a future 3.x release labels Apr 13, 2025
@AThousandShips AThousandShips removed this from the 4.x milestone Apr 13, 2025
@AThousandShips AThousandShips added cherrypick:3.x Considered for cherry-picking into a future 3.x release and removed archived labels Apr 13, 2025
@AThousandShips AThousandShips added this to the 4.x milestone Apr 13, 2025
@nathanfranke
Copy link
Author

nathanfranke commented Apr 13, 2025

Closing for two reasons:

  • Changing copyright should be discussed as an issue or Godot Improvement Proposal (GIP)
  • Public domain is not a worldwide solution to attribution; see Moral rights (wikipedia.org)

I made a PR to track embedding copyright metadata in the svg itself, which resolves my original concern.

See: #105358

@nathanfranke nathanfranke deleted the icon-license branch April 13, 2025 18:56
@AThousandShips AThousandShips added archived and removed cherrypick:3.x Considered for cherry-picking into a future 3.x release labels Apr 13, 2025
@AThousandShips AThousandShips removed this from the 4.x milestone Apr 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants