Skip to content

GDScript: Fix stack overflow when using multiple await#61463

Merged
akien-mga merged 1 commit into
godotengine:masterfrom
vnen:gdscript-await-stack
May 31, 2022
Merged

GDScript: Fix stack overflow when using multiple await#61463
akien-mga merged 1 commit into
godotengine:masterfrom
vnen:gdscript-await-stack

Conversation

@vnen
Copy link
Copy Markdown
Member

@vnen vnen commented May 27, 2022

This fixes a regression caused by #61003. I tested this PR with the example #57126 and could not reproduce the crash nor the leak, so I assume I didn't undo the fix.

Fixes #61130

@vnen vnen added this to the 4.0 milestone May 27, 2022
@vnen vnen requested a review from a team as a code owner May 27, 2022 12:19
@vnen vnen force-pushed the gdscript-await-stack branch from 0167198 to 328aadc Compare May 27, 2022 12:31
@akien-mga akien-mga merged commit c881f60 into godotengine:master May 31, 2022
@akien-mga
Copy link
Copy Markdown
Member

Thanks!

@vnen vnen deleted the gdscript-await-stack branch June 2, 2022 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[4.x regression] while true: await frame causes Stack Overflow

2 participants