Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.5] ResourceImporterWAV: Fix support for 64-bit IEEE float #61169

Merged
merged 1 commit into from
Jul 2, 2022
Merged

[3.5] ResourceImporterWAV: Fix support for 64-bit IEEE float #61169

merged 1 commit into from
Jul 2, 2022

Conversation

DeeJayLSP
Copy link
Contributor

@DeeJayLSP DeeJayLSP commented May 18, 2022 •
edited
Loading

Fixes #61163 for 3.x

Backport of #61168

@DeeJayLSP DeeJayLSP requested a review from a team as a code owner May 18, 2022 20:23
@Calinou Calinou added this to the 3.5 milestone May 18, 2022
@DeeJayLSP
Copy link
Contributor Author

DeeJayLSP commented May 19, 2022 •
edited
Loading

This PR also refactors the code to ensure that, unless someone manages to export some WAV at 128-bit IEEE float or beyond, no unsupported format will be loaded.

This is not a feature implementation, just a fix to something that was added by mistake

@DeeJayLSP DeeJayLSP changed the title [3.x] ResourceImporterWAV: Add support for 64-bit IEEE float [3.x] ResourceImporterWAV: Fix support for 64-bit IEEE float May 20, 2022
@DeeJayLSP DeeJayLSP changed the title [3.x] ResourceImporterWAV: Fix support for 64-bit IEEE float [3.5/3.x] ResourceImporterWAV: Fix support for 64-bit IEEE float May 21, 2022
@DeeJayLSP
Copy link
Contributor Author

I think this should have been labelled as bug

@Calinou Calinou added bug and removed enhancement labels May 24, 2022
@fire fire requested a review from a team June 7, 2022 12:40
akien-mga
akien-mga approved these changes Jul 2, 2022
View reviewed changes
Copy link
Member

@akien-mga akien-mga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@akien-mga akien-mga merged commit bed3d2c into godotengine:3.x Jul 2, 2022
@akien-mga
Copy link
Member

Thanks!

@DeeJayLSP DeeJayLSP changed the title [3.5/3.x] ResourceImporterWAV: Fix support for 64-bit IEEE float [3.5] ResourceImporterWAV: Fix support for 64-bit IEEE float Jul 2, 2022
@DeeJayLSP DeeJayLSP deleted the wav_ieee_3.x branch July 2, 2022 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
bug topic:audio topic:import
Projects
None yet
Milestone
3.5
Development

Successfully merging this pull request may close these issues.
3 participants
@DeeJayLSP @akien-mga @Calinou