-
-
Notifications
You must be signed in to change notification settings - Fork 20.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add TorusMesh
#60843
Add TorusMesh
#60843
Conversation
5068114
to
3fffd95
Compare
Added tangents. All it's missing now is the resource icon. |
What's the rationale for adding this as a primitive mesh? This is the kind of change that requires a proposal to discuss the use case and whether it makes sense to add things to the API. |
CSGTorus3D exists and this was intended to replace it internally when removing redundant CSG primitive generation code. |
Now that #59077 is closed this is solely to have a torus primitive mesh. CSG has one already. |
I tested this PR locally, it works as expected. However, if
I suggest adding an human-readable error message by checking for the inner and outer radius' values with
I made an icon for TorusMesh based on the CSGTorus3D icon 🙂 Save this file as |
@Calinou Added your suggestions! |
Thanks! |
PrimitiveMesh counterpart to
CSGTorus3D
.Required for #59077.