Make blend animation to use ResetTrack as default value #60093
Merged
+172
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #59961. Also fixed #59474 as side effect.
Make blend animation to use ResetTrack as default value.
This fix allows non
Skeleton3D::Bone.bone_posevalue to have a default value like Bone Rest, which will blend with the intended default value instead of the zero value when the track of the animations to be blended are missing.Without this, it means that most blend animations will not allow missing tracks. And it causes an increase in the number of tracks and the number of animations in combination. See #59961 (comment) for the reason why the previous blending behavior with missing track cannot be kept by #57675.