Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.x] Rename NavigationServer's free method to free_rid #60018

Merged
merged 1 commit into from
Apr 13, 2022
Merged

[3.x] Rename NavigationServer's free method to free_rid #60018

merged 1 commit into from
Apr 13, 2022

Conversation

timothyqiu
Copy link
Member

@timothyqiu timothyqiu commented Apr 8, 2022 •
edited
Loading

3.x version of #60017

Unlike on master, Object.free() hides NavigationServer.free() here. So users are unable to free allocated RIDs.

SCRIPT ERROR: Invalid call to function 'free' in base 'Navigation2DServer'. Expected 0 arguments.

@timothyqiu timothyqiu added this to the 3.5 milestone Apr 8, 2022
@timothyqiu timothyqiu requested a review from a team as a code owner April 8, 2022 09:50
@akien-mga akien-mga merged commit 8855d73 into godotengine:3.x Apr 13, 2022
@akien-mga
Copy link
Member

Thanks!

@timothyqiu timothyqiu deleted the nav-server-free-3.x branch April 13, 2022 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
bug topic:navigation
Projects
None yet
Milestone
3.5
Development

Successfully merging this pull request may close these issues.
2 participants
@timothyqiu @akien-mga