Delay font texture update, until draw is called. Rasterize glyphs during shaping.
#59862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bruvzg
force-pushed
the
font_delay_texture_update
branch
from
4827301
to
aad9d14
Compare
akien-mga
reviewed
Apr 6, 2022
| } | ||
| if (mh > texsize) { // Special case, adapt to it? | ||
| #ifdef GDEXTENSION | ||
| texsize = Math::next_power_of_2(mh); |
There was a problem hiding this comment.
That's for a separate PR, but we could probably move the po2 methods to Math in core.
akien-mga
approved these changes
Apr 6, 2022
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should increase new font loading (and maybe startup times), font variation changes and rendering text with the glyph that was not used before. Instead of updating the texture when each new glyph is encountered, all glyphs updates are processed at once, and only when trying to draw.
Substantially, decreases the number of times font texture is uploaded to GPU. For Project Manager opening from
100to4. And from160to38when opening simple project with some extra fonts used.