Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.x] (Bullet) collide_shape: return contact points in world space #59470

Merged
merged 1 commit into from
Mar 24, 2022
Merged

[3.x] (Bullet) collide_shape: return contact points in world space #59470

merged 1 commit into from
Mar 24, 2022
+5 −4

Conversation

rburing
Copy link
Member

@rburing rburing commented Mar 24, 2022

This makes it consistent with GodotPhysics.

Fixes #45680.

@rburing rburing requested a review from a team as a code owner March 24, 2022 13:50
@akien-mga akien-mga added this to the 3.5 milestone Mar 24, 2022
fabriceci
fabriceci approved these changes Mar 24, 2022
View reviewed changes
Copy link
Contributor

@fabriceci fabriceci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried with the minimal project provided, this PR fixes the problem, by switching to the global coordinate, the result matches the GodotPhysics one (which was correct).

@akien-mga akien-mga merged commit 78e9441 into godotengine:3.x Mar 24, 2022
@akien-mga
Copy link
Member

Thanks!

@rburing rburing deleted the collide_shape_global branch March 25, 2022 07:58
@akien-mga akien-mga mentioned this pull request May 19, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga left review comments

@fabriceci fabriceci fabriceci approved these changes

Assignees
No one assigned
Labels
bug topic:physics
Projects
None yet
Milestone
3.5
Development

Successfully merging this pull request may close these issues.
3 participants
@rburing @akien-mga @fabriceci