Avoid falling back to the headless display server #59074
Closed
+10
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RandomShaper
force-pushed
the
no_fall_back_to_headless
branch
3 times, most recently
from
f2c7a17
to
045040a
Compare
RandomShaper
force-pushed
the
no_fall_back_to_headless
branch
from
045040a
to
3156aeb
Compare
akien-mga
reviewed
Mar 12, 2022
| @@ -1571,13 +1571,23 @@ Error Main::setup2(Thread::ID p_main_tid_override) { | |||
| } | |||
| display_server = DisplayServer::create(i, rendering_driver, window_mode, window_vsync_mode, window_flags, window_size, err); | |||
| if (err == OK && display_server != nullptr) { | |||
| if (display_server->get_name() == "headless") { | |||
There was a problem hiding this comment.
Hm it seems like a workaround to handle this after the fact. I'd expect the create function to return an error if the requested driver is not suitable, instead of falling back to headless automatically.
There was a problem hiding this comment.
So you'd be in favor of removing this loop that tries to fall back to another display server?
('Driver' and 'display server' terms are a bit mixed in this code. There are plans to uncouple both, so I guess this logic is going to be overhauled in any case.)
There was a problem hiding this comment.
Or you mean that there should be a way to filter out the headless before creating it?
|
Superseded by #62556. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For conext, see #58927 (which may is at least partially addressed by this PR).