Add get_screen_refresh_rate() to OS
#58812
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calinou
force-pushed
the
os-add-get-screen-refresh-rate-3.x
branch
from
773129a
to
dc8facd
Compare
|
Judging by the screenshot, you should also backport the follow up that limited decimal precision to 2 places. |
Calinou
force-pushed
the
os-add-get-screen-refresh-rate-3.x
branch
from
dc8facd
to
3d84d6c
Compare
I did, but it doesn't appear to work as expected: https://github.com/godotengine/godot/blob/3d84d6c68294a992ea5b829042ec94414da5c32c/platform/x11/os_x11.cpp#L1368-L1369 It's strange because in GDScript, |
Calinou
force-pushed
the
os-add-get-screen-refresh-rate-3.x
branch
from
3d84d6c
to
574673e
Compare
m4gr3d
requested changes
Mar 7, 2022
Calinou
force-pushed
the
os-add-get-screen-refresh-rate-3.x
branch
from
574673e
to
362871d
Compare
akien-mga
reviewed
Mar 10, 2022
This method can be used to get the refresh rate of a given screen. It is supported on Windows, macOS, Linux, Android and iOS (but not HTML5).
Calinou
force-pushed
the
os-add-get-screen-refresh-rate-3.x
branch
from
362871d
to
cec7c90
Compare
m4gr3d
approved these changes
Mar 11, 2022
akien-mga
approved these changes
Mar 11, 2022
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This method can be used to get the refresh rate of a given screen. It is supported on Windows, macOS, Linux, Android and iOS (but not HTML5).
3.xversion of #57335.I've only tested this on Linux, Windows (via WINE) and Android so far, so testing on other platforms is welcome.
Testing project: test_refresh_rate_3.x.zip
Windows 64-bit export: UnnamedProject-windows.zip
Android export: UnnamedProject-android.zip
Preview