Clamp BaseMaterial3D triplanar sharpness to values that never look broken #58600
+8
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just wondering for triage, is there anything wrong with this PR ? It is old so we may want to merge it if it's fine :) |
We don't automatically merge PRs if they're old and have no reviews. We still need review from a qualified maintainer before we can merge this PR. |
clayjohn
approved these changes
Aug 18, 2022
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
masterversion of #58601.An alternative solution I was thinking about was to switch to a "hard" cutoff that only performs one sample per pixel when the sharpness is greater than 150. This would also improve performance in situations where you don't need triplanar mapping to smoothly blend between textures (e.g. in hard surface level design with CSG nodes).
That said, this may be better suited to a dedicated boolean property.
This closes #58587.
Testing project: test_triplanar2.zip