Fixed cubic interpolate with loop #58344
Merged
+11
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fire
approved these changes
Feb 20, 2022
There was a problem hiding this comment.
I'm not able to check the results of LOOP_PING_PONG cubic interpolate in its entirety, but TokageIt / Reduz know the most about this area and my [branch] master...V-Sekai:fix-cubic_slerp continues to improve on quaternion cubic interpolate.
reduz
approved these changes
Feb 22, 2022
|
Thanks! |
akien-mga
added
the
cherrypick:3.x
|
This could use a dedicated backport PR for |
|
@akien-mga For now, cherry-picked as #58651. |
akien-mga
removed
the
cherrypick:3.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersede #54811. In the pingpong loop, it is wrong to interpolate between the end and first keys, so this has been fixed.
Fixed #20087.