Fix new performance regressions (short delay_usec) #58081
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tavurth
force-pushed
the
bugfix/high-macos-cpu-usage
branch
2 times, most recently
from
561ea35
to
2cdb593
Compare
|
For some reason the windows release build failed, I'll try to re-run the build process. |
Faless
reviewed
Feb 14, 2022
My Mac was using 20% cpu again, which was related to the Javascript Export plugin. I had however no export templates setup in the project so this is more of a stopgap fix.
tavurth
force-pushed
the
bugfix/high-macos-cpu-usage
branch
from
2cdb593
to
ab5eaf0
Compare
Faless
approved these changes
Feb 15, 2022
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My Mac was using 20% cpu again, which was related to the Javascript
Export plugin.
I had however no export templates setup in the project so this is more
of a stopgap fix.
See here for a more complete description of this issue: #58082
For now I'd just like my performance back :)
Before:
After
So a reduction of around
400mswasted CPU time. Now most CPU usage seems now to be coming fromCoreAudio